lkml.org 
[lkml]   [2015]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 0/5] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller
From
Date


On Friday 04 September 2015 09:02 PM, Vaibhav Hiremath wrote:
> PXA1928 SDHCI controller has few differences, for example,
>
> PXAxxx PXA1928
> ====== =======
> SDCLK_DELAY field 0x10A 0x114
> SDCLK_DELAY mask 0x1F 0x3FF
> SDCLK_DELAY shift 9 8
> SDCLK_SEL shift 8 2 (SEL1)
>
> So this patch series introduces new compatible device_id
> (marvell,pxav3-1928-sdhci), and makes use of .data for handling
> such differences.
>
> The series also adds support like,
>
> - independent ->set_clock() api, as we need to enable internal clock gate
> and TX clock
> - pinctrl configuration based on bus speed.
> - introduce new quirk SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER
> SD_BUS_POWER & SD_BUS_VLT bit-fields are used internally to gate the
> clocks, so it is important to configure them as part of ->set_power()
> More detailed description is written into commit log.
> - Enable SDHCI_QUIRK_BROKEN_TIMEOUT_VAL for PXA1928 device_id
>

Please ignore this series, as one residual change (rather typo error).
Mistakenly while checking in the code, instead of 1928 compatible
property it was 988.

I will submit the new series shortly.

Thanks,
Vaibhav


>
> Testing:
> I have done basic testing on both eMMC and SD card on PXA1928 based
> platform.
>
> Note: I tried to made sure that I do not break any other platform, which
> used sdhci, except HS200 configuration.
> Unfortunately I do not have access to any other datasheets, where I can
> cross check the details on HS200 bit-fields. Probably someone who has
> access can confirm [PATCH 4/5], whether it impacts other platforms.
>
> Kevin Liu (1):
> mmc: sdhci-pxav3: Fix HS200 mode support
>
> Vaibhav Hiremath (4):
> mmc: sdhci-pxav3: Enable pxa1928 device support
> mmc: sdhci-pxav3: Add platform specific set_clock ops
> mmc: sdhci-pxav3: Add pinctl setting according to bus clock
> mmc: sdhci: add new quirk for setting BUS_POWER & BUS_VLT fields
>
> drivers/mmc/host/sdhci-pltfm.c | 3 +
> drivers/mmc/host/sdhci-pxav3.c | 168 ++++++++++++++++++++++++++++++++++++++---
> drivers/mmc/host/sdhci.c | 3 +-
> drivers/mmc/host/sdhci.h | 2 +
> 4 files changed, 163 insertions(+), 13 deletions(-)
>


\
 
 \ /
  Last update: 2015-09-07 13:01    [W:0.040 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site