lkml.org 
[lkml]   [2015]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: slicoss: remove unused variables
On Fri, Sep 04, 2015 at 11:13:00AM -0700, David Matlack wrote:
> On Fri, Sep 4, 2015 at 6:23 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > These variables were only assigned some values but they were never used.
> >
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
<snip>
> > - status = slic_upr_request(adapter, SLIC_UPR_RLSR,
> > - (u32) &pshmem->linkstatus, /* no 4GB wrap guaranteed */
> > - 0, 0, 0);
> > + slic_upr_request(adapter, SLIC_UPR_RLSR,
> > + (u32)&pshmem->linkstatus, /* no 4GB wrap guaranteed */
> > + 0, 0, 0);
>
> Is status safe to ignore?
status can have two value either -ENOMEM or STATUS_PEMDING.
Ideally we should have handled -ENOMEM.

regards
sudip


\
 
 \ /
  Last update: 2015-09-05 10:41    [W:1.666 / U:1.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site