lkml.org 
[lkml]   [2015]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues
On Fri, Sep 04, 2015 at 05:48:55PM +0000, Jose Rivera wrote:
> > -----Original Message-----
> > From: Nayeemahmed Badebade [mailto:itachi.opsrc@gmail.com]
> > Sent: Friday, September 04, 2015 12:01 PM
> > To: gregkh@linuxfoundation.org
> > Cc: Rivera Jose-B46482; Yoder Stuart-B08248; agraf@suse.de;
> > hgujulan@visteon.com; linux-kernel@vger.kernel.org
> > Subject: [PATCH] Staging: fsl-mc/bus: mc-bus.c: Fixed coding style issues
> >
> > Fixed coding style issues where kernel types u16,u64,u32 should be
> > preferred over uint16_t,uint64_t,uint32_t
> >
> Nayeemahmed,
>
> Thanks for your interests in helping us clean up this coding style issue.
> However, doing this for all the files related to the MC bus driver (not just
> for one) is something that I intend to do in a future patch as
> part of the "Cleanup" item of our TODO list.
> Doing this clean up across the board for all files is preferable than
> doing it just for this file in this patch.

Sorry, but we never postpone a change submitted by someone just because
someone says "sometime in the future we will be making much the same
change". That's a sure way to kill productivity and stop developers
from helping you out.

If you really wanted to make this type of change, you would have done so
already, so obviously it's not a high priority. I'll take Nayeemahmed's
patch.

greg k-h


\
 
 \ /
  Last update: 2015-09-04 20:21    [W:3.223 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site