Messages in this thread | | | Subject | Re: [PATCH v2] Makefile: Fix detection of clang when cross-compiling | From | Michal Marek <> | Date | Fri, 4 Sep 2015 13:25:19 +0200 |
| |
On 2015-08-27 10:37, Michal Marek wrote: > On 2015-08-27 03:49, Behan Webster wrote: >> Is there any reason you renamed COMPILER? Because it breaks all the >> other patches we have queued up which use it for cross compiling. >> >> And aren't we supposed to use all caps for variable names? > > It more like a function now and is consistent with the other cc-* > definitions in scripts/Kbuild.include. > > >> This doesn't only break powerpc, it breaks arm, aarch64 and clang work >> that's being done on MIPS malta. > > So do a s/COMPILER/cc-name/ ? You can merge my patch into your tree to > avoid a dependency on the kbuild tree.
Since I haven't seen any further uses of the $(CLANG) variable in linux-next, I applied the patch to kbuild.git now.
Michal
| |