Messages in this thread | | | Date | Wed, 30 Sep 2015 20:11:54 +0200 | From | Jesper Nilsson <> | Subject | Re: [PATCH] cris: kgdb: use native hex2bin |
| |
On Wed, Sep 30, 2015 at 08:02:34PM +0200, Jesper Nilsson wrote: > On Wed, Sep 30, 2015 at 06:37:51PM +0300, Andy Shevchenko wrote: > > On Wed, 2015-09-30 at 17:22 +0200, Jesper Nilsson wrote: > > > On Wed, Sep 30, 2015 at 04:46:53PM +0200, Andy Shevchenko wrote: > > > > On Tue, 2013-06-04 at 11:51 +0300, Andy Shevchenko wrote: > > > > > There are kernel native helpers to convert hex ascii to the > > > > > binary > > > > > format: > > > > > hex_to_bin() and hex2bin(). Thus, no need to reimplement them > > > > > customly. > > > > > > > > > > > > > No one is interested in this? > > > > > > Hm, dunno why, but obviously I've missed these patches, > > > and I can't find them on my main mailaccount either. > > > > > > Anyways, I found them on a secondary account, and have > > > added them to the CRIS linux-next tree. > > > > Just noticed that it was along time ago and currently it might produce > > compile warnings or errors since now hex2bin is prefixed by > > __must_check. > > > > Would you like me to send v2? > > Unless you've tweaked them more since you sent them, > it shouldn't be necessary, the patches applied cleanly. > Those (most) files in CRIS are not touched very often... :-)
... and now I saw your v2, I'll take that instead since you already fixed the __must_check problems.
Thanks a lot!
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com>
/^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com
| |