lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: comedi: ni_tiocmd: remove unused code
On 29/09/15 12:22, Luis de Bethencourt wrote:
> Code after a return will never run, removing this dead code.
>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hi,
>
> This is a better fix than the previous patch:
> http://lkml.iu.edu/hypermail/linux/kernel/1509.3/02741.html
>
> Suggestion of just removing the dead code was in:
> http://lkml.iu.edu/hypermail/linux/kernel/1509.3/02939.html
>
> Thanks,
> Luis
>
> drivers/staging/comedi/drivers/ni_tiocmd.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c
> index 9b124b0..437f723 100644
> --- a/drivers/staging/comedi/drivers/ni_tiocmd.c
> +++ b/drivers/staging/comedi/drivers/ni_tiocmd.c
> @@ -157,12 +157,6 @@ static int ni_tio_output_cmd(struct comedi_subdevice *s)
> dev_err(counter->counter_dev->dev->class_dev,
> "output commands not yet implemented.\n");
> return -ENOTSUPP;
> -
> - counter->mite_chan->dir = COMEDI_OUTPUT;
> - mite_prep_dma(counter->mite_chan, 32, 32);
> - ni_tio_configure_dma(counter, true, false);
> - mite_dma_arm(counter->mite_chan);
> - return ni_tio_arm(counter, 1, NI_GPCT_ARM_IMMEDIATE);
> }
>
> static int ni_tio_cmd_setup(struct comedi_subdevice *s)
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-09-30 16:41    [W:0.075 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site