lkml.org 
[lkml]   [2015]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 net-next 0/6] net: switchdev: use specific switchdev_obj_*
Tue, Sep 29, 2015 at 06:07:12PM CEST, vivien.didelot@savoirfairelinux.com wrote:
>This patchset changes switchdev add, del, dump operations from this:
>
> int (*switchdev_port_obj_add)(struct net_device *dev,
> struct switchdev_obj *obj,
> struct switchdev_trans *trans);
> int (*switchdev_port_obj_del)(struct net_device *dev,
> struct switchdev_obj *obj);
> int (*switchdev_port_obj_dump)(struct net_device *dev,
> struct switchdev_obj *obj);
>
>to something similar to the notifier_call callback of a notifier_block:
>
> int (*switchdev_port_obj_add)(struct net_device *dev,
> enum switchdev_obj_id id,
> const void *obj,
> struct switchdev_trans *trans);
> int (*switchdev_port_obj_del)(struct net_device *dev,
> enum switchdev_obj_id id,
> const void *obj);
> int (*switchdev_port_obj_dump)(struct net_device *dev,
> enum switchdev_obj_id id, void *obj,
> int (*cb)(void *obj));
>
>This allows the caller to pass and expect back a specific switchdev_obj_*
>structure (e.g. switchdev_obj_fdb) instead of the generic switchdev_obj one.
>
>This will simplify pushing the callback function down to the drivers.
>
>The first 3 patches get rid of the dev parameter of the dump callback, since it
>is not always neeeded (e.g. vlan_dump) and some drivers (such as DSA drivers)
>may not have easy access to it.
>
>Patches 4 and 5 implement the change in the switchdev operations and its users.
>
>Patch 6 extracts the inner switchdev_obj_* structures from switchdev_obj and
>removes this last one.


How about attrs? We should keep objs and attrs api consistent.


\
 
 \ /
  Last update: 2015-09-30 13:01    [W:0.080 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site