Messages in this thread | | | Date | Thu, 3 Sep 2015 18:16:41 -0700 | Subject | Re: [RFC PATCH] mmc: block: Add new ioctl to send combo commands | From | Grant Grundler <> |
| |
[resending...keep forgetting to switch back to text-only in gmail]
On Thu, Sep 3, 2015 at 8:10 AM, Jon Hunter <jonathanh@nvidia.com> wrote: ... >>> If alignment matters, then maybe swap the fields? >>> Or declare num_of_cmds as u64 as well? > > Thanks. I did swap them in the updated version as this seems to make > sense. However, I left num_of_cmds as an 8-bit value unless someone has > a need for more than 256 commands ;-)
Awesome - thanks! I saw that in the new version you posted. LGTM. You or Ulf can add "Reviewed by: Grant Grundler <grundler@chromium.org"
(I just switched the "reply-from:" on you ;)
Ulf, anything else stand out?
I normally don't like to rush but we'd at least like confirmation that struct mmc_ioc_combo_cmd is acceptable as is (since it's the main part of the API).
thanks, grant
| |