Messages in this thread | | | Subject | Re: [PATCH] null_blk: fix memory leak on cleanup | From | Matias Bjorling <> | Date | Thu, 3 Sep 2015 07:48:34 +0200 |
| |
Den 02-09-2015 kl. 20:39 skrev Ross Zwisler: > On Mon, Aug 31, 2015 at 02:17:18PM +0200, Matias Bjørling wrote: >> From: Matias Bjørling <mb@lightnvm.io> >> >> Driver was not freeing the memory allocated for internal nullb queues. >> This patch frees the memory during driver unload. > > You may want to consider devm_* style allocations instead. These are freed > automatically on driver unload, simplifying your error paths and your unload > logic as well as preventing leaks. > > See this patch for an example: > > https://lkml.org/lkml/2015/8/10/992 >
Thanks for looking through the patches. I'll look into it.
| |