Messages in this thread Patch in this message | | | Subject | Re: [PATCH 2/3] selftests: add membarrier syscall test | From | Michael Ellerman <> | Date | Thu, 03 Sep 2015 19:33:59 +1000 |
| |
On Tue, 2015-09-01 at 11:32 -0700, Andy Lutomirski wrote: > On Tue, Sep 1, 2015 at 10:11 AM, Mathieu Desnoyers > <mathieu.desnoyers@efficios.com> wrote: > > Just to make sure I understand: should we expect that > > everyone will issue "make headers_install" on their system > > before doing a make kselftest ? > > > > I see that a few selftests (e.g. memfd) are adding the > > source tree include paths to the compiler include paths, > > which I guess is to ensure that the kselftest will > > work even if the system headers are not up to date. > > It would be really nice if there were a clean way for selftests to > include the kernel headers.
What's wrong with make headers_install?
Or do you mean when writing the tests? That we could fix by adding the ../../../../usr/include path to CFLAGS in lib.mk. And fixing all the tests that overwrite CFLAGS to append to CFLAGS.
> Perhaps make should build the exportable headers somewhere as a dependency of > kselftests.
Yeah the top-level kselftest target could do that I think.
Folks who don't want the headers installed can just run the selftests Makefile directly.
Does this work for you?
diff --git a/Makefile b/Makefile index c361593..c8841d3 100644 --- a/Makefile +++ b/Makefile @@ -1080,7 +1080,7 @@ headers_check: headers_install # Kernel selftest PHONY += kselftest -kselftest: +kselftest: headers_install $(Q)$(MAKE) -C tools/testing/selftests run_tests # --------------------------------------------------------------------------- cheers
| |