lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 0/7] blk-mq: fix race conditions on cpu hotplug handling
From
Date
On 09/26/2015 11:09 AM, Akinobu Mita wrote:
> This patchset addresses several race conditions on cpu hotplug handling
> for blk-mq. All problems can be reproducible by the following script.
>
> while true; do
> echo 0 > /sys/devices/system/cpu/cpu1/online
> echo 1 > /sys/devices/system/cpu/cpu1/online
> done &
>
> while true; do
> modprobe -r null_blk
> modprobe null_blk queue_mode=2 irqmode=1
> sleep 0.1
> done
>
> * Changes from v3
> - Rebased to the latest kernel
> - Add Reviewed-by tags

I've reviewed the patches, looks good to me. I've skipped 6/7, as I
think we should fix that as part of the percpu ref counting, and not
handle it specifically in blk-mq. If we can't get that fix before 4.3
wraps up, then we can revisit and put that in as well.

Thanks!

--
Jens Axboe



\
 
 \ /
  Last update: 2015-09-29 19:41    [W:0.175 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site