lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ver_linux: uniform output across various linux distros
    On Tue, Sep 29, 2015 at 06:36:12PM +0300, Alexander Kapshuk wrote:
    > I've reread 'Documentation/SubmittingPatches', and opted for method 1
    > to create the patch.
    >
    > When you mentioned about the patch changing the formatting, were you
    > referring to the formatting of the actual script, or the output the
    > script generated? If it's the former, I'm not sure I'm clear on how to
    > keep separate the changes made to the code base from the changes in
    > the formatting of the new code base introduced by these changes. If
    > it's the latter, the overall output generated by the script is mostly
    > identical to that generated by the original implementation.
    >
    > If the patch below is still off the mark, I apologise for that, and
    > would appreciate being pointed out what else needs changing, when you
    > have the time. I understand you having more pressing matters to attend
    > to.
    >
    > Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>

    This is the "oddest" changelog comments I've ever seen for a patch, it
    doesn't describe what it is doing at all :)

    Please fix up, and resend the whole thing correctly, so we can review
    that.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2015-09-29 19:01    [W:5.236 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site