lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets
On Wed, 23 Sep 2015, Oleksij Rempel wrote:

Subject: irqchip/mxs: ..... Please

> +struct icoll_priv {
> + void __iomem *vector;
> + void __iomem *levelack;
> + void __iomem *ctrl;
> + void __iomem *stat;
> + void __iomem *intr;
> + /* number of interrupts per register */
> + int intr_per_reg;

Why are you adding this here just to remove it in the next patch?

> + void __iomem *clear;

Please do not add members which are not required for the preparatory
step.

Thanks,

tglx


\
 
 \ /
  Last update: 2015-09-29 18:21    [W:0.066 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site