lkml.org 
[lkml]   [2015]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.10 35/56] net/tipc: initialize security state for new connection socket
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Stephen Smalley <sds@tycho.nsa.gov>

    [ Upstream commit fdd75ea8df370f206a8163786e7470c1277a5064 ]

    Calling connect() with an AF_TIPC socket would trigger a series
    of error messages from SELinux along the lines of:
    SELinux: Invalid class 0
    type=AVC msg=audit(1434126658.487:34500): avc: denied { <unprintable> }
    for pid=292 comm="kworker/u16:5" scontext=system_u:system_r:kernel_t:s0
    tcontext=system_u:object_r:unlabeled_t:s0 tclass=<unprintable>
    permissive=0

    This was due to a failure to initialize the security state of the new
    connection sock by the tipc code, leaving it with junk in the security
    class field and an unlabeled secid. Add a call to security_sk_clone()
    to inherit the security state from the parent socket.

    Reported-by: Tim Shearer <tim.shearer@overturenetworks.com>
    Signed-off-by: Stephen Smalley <sds@tycho.nsa.gov>
    Acked-by: Paul Moore <paul@paul-moore.com>
    Acked-by: Ying Xue <ying.xue@windriver.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/tipc/socket.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/net/tipc/socket.c
    +++ b/net/tipc/socket.c
    @@ -1528,6 +1528,7 @@ static int accept(struct socket *sock, s
    res = tipc_create(sock_net(sock->sk), new_sock, 0, 0);
    if (res)
    goto exit;
    + security_sk_clone(sock->sk, new_sock->sk);

    new_sk = new_sock->sk;
    new_tsock = tipc_sk(new_sk);



    \
     
     \ /
      Last update: 2015-09-29 16:21    [W:4.131 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site