Messages in this thread | | | Date | Tue, 29 Sep 2015 10:55:09 +0100 | From | Luis de Bethencourt <> | Subject | Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code |
| |
On 29/09/15 02:23, Greg KH wrote: > On Mon, Sep 28, 2015 at 10:10:42PM +0100, Luis de Bethencourt wrote: >> Remove the disabled code, for now, with #if 0. >> >> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> >> --- >> >> Hi, >> >> The code after the return is dead code. There is a comment saying it is >> disabled for now, it would be good if the code is removed with #if 0 as >> well. > > The compiler doesn't add it anyway, so this is the same as what you just > did, so I don't think it's needed. > > thanks, > > greg k-h >
Hi Greg,
I thought it would be easier to read if the code was explicitly marked as dead/uncompiled. You are correct though, it is probably not worth it.
Thanks for the review, Luis
| |