Messages in this thread | | | From | Jes Sorensen <> | Subject | Re: [PATCH v2] staging: rtl8723au: Fix resource leak | Date | Mon, 28 Sep 2015 14:23:19 -0400 |
| |
Mateusz Kulikowski <mateusz.kulikowski@gmail.com> writes: > Firmware was not released properly if kmemdup fails. > > Addresses-Coverity-Id: 1269118 > Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> > --- > drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
> > diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > index cd014f7..ecf54ee 100644 > --- a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > +++ b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c > @@ -249,13 +249,13 @@ int rtl8723a_FirmwareDownload(struct rtw_adapter *padapter) > goto Exit; > } > firmware_buf = kmemdup(fw->data, fw->size, GFP_KERNEL); > + fw_size = fw->size; > + release_firmware(fw); > if (!firmware_buf) { > rtStatus = _FAIL; > goto Exit; > } > buf = firmware_buf; > - fw_size = fw->size; > - release_firmware(fw); > > /* To Check Fw header. Added by tynli. 2009.12.04. */ > pFwHdr = (struct rt_8723a_firmware_hdr *)firmware_buf;
| |