lkml.org 
[lkml]   [2015]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 3/3] Thermal: do thermal zone update after a cooling device registered
Date
Hi, Javi,

> -----Original Message-----
> From: Javi Merino [mailto:javi.merino@arm.com]
> Sent: Monday, September 28, 2015 10:29 PM
> To: Chen, Yu C
> Cc: linux-pm@vger.kernel.org; edubezval@gmail.com; Zhang, Rui; linux-
> kernel@vger.kernel.org; stable@vger.kernel.org
> Subject: Re: [PATCH 3/3] Thermal: do thermal zone update after a cooling
> device registered
>
> On Sun, Sep 27, 2015 at 06:48:44AM +0100, Chen Yu wrote:
> > From: Zhang Rui <rui.zhang@intel.com>
> >
> >
>
> I think you need to hold cdev->lock here, to make sure that no thermal zone
> is added or removed from cdev->thermal_instances while you are looping.
>
Ah right, will add. If I add the cdev ->lock here, will there be a AB-BA lock with
thermal_zone_unbind_cooling_device?

>
> Why list_for_each_entry_safe() ? You are not going to remove any entry, so
> you can just use list_for_each_entry()
>
>
> Why is this so complicated? Can't you just do:
>
> list_for_each_entry(pos, &cdev->thermal_instances, cdev_node)
> thermal_zone_device_update(pos->tz);
>

This is an optimization here:
Ignore thermal instance that refers to the same thermal zone in this loop,
this works because bind_cdev() always binds the cooling device to one
thermal zone first, and then binds to the next thermal zone.


Best Regards,
Yu
\
 
 \ /
  Last update: 2015-09-28 20:21    [W:0.045 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site