lkml.org 
[lkml]   [2015]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before suspend-to-idle
Date
On Monday, September 28, 2015 01:51:09 AM Chen, Yu C wrote:
> Hi, Rafael,
>
> > -----Original Message-----
> > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
> > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
> > Sent: Sunday, September 27, 2015 9:30 PM
> > To: Chen, Yu C
> > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown, Len; linux-
> > kernel@vger.kernel.org; linux-pm@vger.kernel.org
> > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq setting before
> > suspend-to-idle
> >
> > On Saturday, September 26, 2015 02:37:19 PM Chen, Yu C wrote:
> > > Hi, Rafael,
> > >
> > > > -----Original Message-----
> > > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
> > > > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki
> > > > Sent: Friday, September 25, 2015 9:57 PM
> > > > To: Chen, Yu C
> > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui; Brown,
> > > > Len; linux- kernel@vger.kernel.org; linux-pm@vger.kernel.org
> > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
> > > > setting before suspend-to-idle
> > > >
> > > > On Friday, September 25, 2015 06:42:41 AM Chen, Yu C wrote:
> > > > > Hi,Rafael, thanks a lot for your review, will resend v2 version.
> > > > >
> > > > > > -----Original Message-----
> > > > > > From: Rafael J. Wysocki [mailto:rjw@rjwysocki.net]
> > > > > > Sent: Friday, September 25, 2015 9:24 AM
> > > > > > To: Chen, Yu C
> > > > > > Cc: Wysocki, Rafael J; jiang.liu@linux.intel.com; Zhang, Rui;
> > > > > > Brown, Len; linux- kernel@vger.kernel.org;
> > > > > > linux-pm@vger.kernel.org
> > > > > > Subject: Re: [PATCH][RFC] ACPI / PM: Fix incorrect wakeup irq
> > > > > > setting before suspend-to-idle
> > > > > >
> > > > > > On Monday, August 10, 2015 10:11:26 AM Chen Yu wrote:
> > > >
> > > > But I'd rather define a global acpi_irq variable, store irq in it
> > > > and access it directly from acpi_freeze_prepare(). And it doesn't
> > > > have to depend on CONFIG_SUSPEND as it is just the IRQ number
> > actually used by ACPI.
> > > >
> > > OK, I've convert it to a global variable acpi_inuse_irq.
> >
> > Why do you need the "inuse" part? Why is acpi_irq not sufficient?
> Because the name of acpi_irq is already used by acpi irq handler at
> drivers/acpi/osl.c:
> request_irq(irq, acpi_irq, IRQF_SHARED, "acpi", acpi_irq)

Ah, this is the name of the handler. I forgot about that, sorry.

Well, it might be worth renaming the handler to something like acpi_interrupt(), then.

Thanks,
Rafael



\
 
 \ /
  Last update: 2015-09-28 14:41    [W:0.063 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site