lkml.org 
[lkml]   [2015]   [Sep]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings
    Date
    >>>>> "kbuild" == kbuild test robot <lkp@intel.com> writes:

    > sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579
    > PTR_ERR should access the value just tested by IS_ERR

    > Semantic patch information:
    > There can be false positives in the patch case, where it is the call
    > IS_ERR that is wrong.

    > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

    > CC: Songjun Wu <songjun.wu@atmel.com>
    > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
    > ---

    > atmel-classd.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)

    > --- a/sound/soc/atmel/atmel-classd.c
    > +++ b/sound/soc/atmel/atmel-classd.c
    > @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla

    dd-> gclk = devm_clk_get(dev, "gclk");
    > if (IS_ERR(dd->aclk)) {
    > - ret = PTR_ERR(dd->gclk);
    > + ret = PTR_ERR(dd->aclk);

    It looks like it is the other way around. It should test
    IS_ERR(dd->gclk) instead.

    --
    Bye, Peter Korsgaard


    \
     
     \ /
      Last update: 2015-09-28 13:41    [W:3.111 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site