Messages in this thread | | | Date | Sun, 27 Sep 2015 17:18:08 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: serio - fix blocking of parport |
| |
On Sat, Sep 26, 2015 at 06:53:21PM +0530, Sudip Mukherjee wrote: > If parkbd_allocate_serio() fails to allocate memory we are releasing the > parport but we missed unregistering the device. As a result this device > with exclusive access to that parport remains registered. And no other > device will be able to use that parport even though this driver has > failed to load. > > Cc: <stable@vger.kernel.org> # 2.6.32+ > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Applied, but I dropped stable annotation - since noone complained about this and the issue is in error path that is unlikely anyway, I do not think we need to bother stable guys with it.
Thanks!
> --- > > Faced this problem while creating the patch series for input to use > parallel port device model. > > drivers/input/serio/parkbd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/input/serio/parkbd.c b/drivers/input/serio/parkbd.c > index 26b4593..1e8cd6f 100644 > --- a/drivers/input/serio/parkbd.c > +++ b/drivers/input/serio/parkbd.c > @@ -194,6 +194,7 @@ static int __init parkbd_init(void) > parkbd_port = parkbd_allocate_serio(); > if (!parkbd_port) { > parport_release(parkbd_dev); > + parport_unregister_device(parkbd_dev); > return -ENOMEM; > } > > -- > 1.9.1 >
-- Dmitry
| |