lkml.org 
[lkml]   [2015]   [Sep]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision
    Date
    This patch is to the rtl871x_ioctl_linux.c that fixes up following
    warning reported by checkpatch.pl :

    - Comparisons should place the constant on the right side of the test

    Signed-off-by: Punit Vara <punitvara@gmail.com>
    ---
    drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
    1 file changed, 8 insertions(+), 8 deletions(-)

    diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
    index 143be0f..6d7f8f7 100644
    --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
    +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
    @@ -957,7 +957,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
    if (IS_ERR(ext))
    return PTR_ERR(ext);

    - if (0 == strcasecmp(ext, "RSSI")) {
    + if (strcasecmp(ext, "RSSI") == 0) {
    /*Return received signal strength indicator in -db for */
    /* current AP */
    /*<ssid> Rssi xx */
    @@ -974,7 +974,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
    } else {
    sprintf(ext, "OK");
    }
    - } else if (0 == strcasecmp(ext, "LINKSPEED")) {
    + } else if (strcasecmp(ext, "LINKSPEED") == 0) {
    /*Return link speed in MBPS */
    /*LinkSpeed xx */
    union iwreq_data wrqd;
    @@ -982,30 +982,30 @@ static int r871x_wx_set_priv(struct net_device *dev,
    int mbps;

    ret_inner = r8711_wx_get_rate(dev, info, &wrqd, extra);
    - if (0 != ret_inner)
    + if (ret_inner != 0)
    mbps = 0;
    else
    mbps = wrqd.bitrate.value / 1000000;
    sprintf(ext, "LINKSPEED %d", mbps);
    - } else if (0 == strcasecmp(ext, "MACADDR")) {
    + } else if (strcasecmp(ext, "MACADDR") == 0) {
    /*Return mac address of the station */
    /* Macaddr = xx:xx:xx:xx:xx:xx */
    sprintf(ext, "MACADDR = %pM", dev->dev_addr);
    - } else if (0 == strcasecmp(ext, "SCAN-ACTIVE")) {
    + } else if (strcasecmp(ext, "SCAN-ACTIVE") == 0) {
    /*Set scan type to active */
    /*OK if successful */
    struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

    pmlmepriv->passive_mode = 1;
    sprintf(ext, "OK");
    - } else if (0 == strcasecmp(ext, "SCAN-PASSIVE")) {
    + } else if (strcasecmp(ext, "SCAN-PASSIVE") == 0) {
    /*Set scan type to passive */
    /*OK if successful */
    struct mlme_priv *pmlmepriv = &padapter->mlmepriv;

    pmlmepriv->passive_mode = 0;
    sprintf(ext, "OK");
    - } else if (0 == strncmp(ext, "DCE-E", 5)) {
    + } else if (strncmp(ext, "DCE-E", 5) == 0) {
    /*Set scan type to passive */
    /*OK if successful */
    r8712_disconnectCtrlEx_cmd(padapter
    @@ -1015,7 +1015,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
    , 5000 /*u32 firstStageTO */
    );
    sprintf(ext, "OK");
    - } else if (0 == strncmp(ext, "DCE-D", 5)) {
    + } else if (strncmp(ext, "DCE-D", 5) == 0) {
    /*Set scan type to passive */
    /*OK if successfu */
    r8712_disconnectCtrlEx_cmd(padapter
    --
    2.5.2


    \
     
     \ /
      Last update: 2015-09-26 19:01    [W:4.057 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site