Messages in this thread | | | Date | Fri, 25 Sep 2015 15:29:07 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH v3 4/4] mm, procfs: Display VmAnon, VmFile and VmShm in /proc/pid/status |
| |
On Wed 05-08-15 15:01:25, Vlastimil Babka wrote: > From: Jerome Marchand <jmarchan@redhat.com> > > It's currently inconvenient to retrieve MM_ANONPAGES value from status > and statm files and there is no way to separate MM_FILEPAGES and > MM_SHMEMPAGES. Add VmAnon, VmFile and VmShm lines in /proc/<pid>/status > to solve these issues.
Yes this is definitely an improvement. I have no strong opinion on naming. VmFOO is consistent with the rest (e.g. VmData, Stk...)
> > Signed-off-by: Jerome Marchand <jmarchan@redhat.com> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: Michal Hocko <mhocko@suse.com> [...] > @@ -82,7 +91,7 @@ unsigned long task_statm(struct mm_struct *mm, > unsigned long *data, unsigned long *resident) > { > *shared = get_mm_counter(mm, MM_FILEPAGES) + > - get_mm_counter(mm, MM_SHMEMPAGES); > + get_mm_counter_shmem(mm); > *text = (PAGE_ALIGN(mm->end_code) - (mm->start_code & PAGE_MASK)) > >> PAGE_SHIFT; > *data = mm->total_vm - mm->shared_vm;
Ahh, so you have fixed up the compilation issue from previous patch here... This really belong to the previous patch as already noted. -- Michal Hocko SUSE Labs
| |