Messages in this thread | | | Date | Fri, 25 Sep 2015 04:32:06 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 08/15] block, dax, pmem: reference counting infrastructure |
| |
On Thu, Sep 24, 2015 at 05:03:18PM -0700, Dan Williams wrote: > That makes sense to me, especially because drivers/nvdimm/blk.c is > broken in the same way as drivers/nvdimm/pmem.c and it would be > awkward to have it use blk_dax_get() / blk_dax_put(). The > percpu_refcount should be valid for all queues and it will only ever > be > 1 in the blk_mq and libnvdimm cases (for now). Will fix.
Looking at this a bit more it might actually make sense to grab the referene in common code before calling into ->make_request.
Jens, any opinion on that?
| |