Messages in this thread | | | From | Michal Nazarewicz <> | Subject | Re: + kernelh-make-abs-work-with-64-bit-types.patch added to -mm tree | Date | Thu, 24 Sep 2015 15:32:55 +0200 |
| |
On Wed, Sep 23 2015, Alexey Dobriyan wrote: > I've sent kabs() before which didn't go in because it didn't work for > INT_MAX et al > (don't worry, this abs() doens't as well) but it is nicer that this > version in other aspects > (hopefully). > > [PATCH v2] Add kabs() > http://marc.info/?l=linux-kernel&m=133518745522740&w=4
Perhaps:
+ (void)(_x))))))); \
instead of:
+ _x)))))); \
at the end. Since kabs makes no sense for unsigned types it’s best to fail with compile-time error than to let user think that the call is actually doing something.
Also, you don’t need ({ … }) around the ‘_x < 0 ? -_x : _x’ expression, do you?
-- Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o ..o | Computer Science, ミハウ “mina86” ナザレヴイツ (o o) ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>-----ooO--(_)--Ooo--
| |