lkml.org 
[lkml]   [2015]   [Sep]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/3] irqchip/gicv3-its: Handle OF device tree "msi-map" properties.
On 09/23/2015 10:01 AM, Marc Zyngier wrote:
> On Tue, 22 Sep 2015 17:00:06 -0700
> David Daney <ddaney.cavm@gmail.com> wrote:
>
>> From: David Daney <david.daney@cavium.com>
>>
>> Call of_msi_map_rid() to handle mapping of the requester id.
>>
>> Signed-off-by: David Daney <david.daney@cavium.com>
>> ---
>> drivers/irqchip/irq-gic-v3-its-pci-msi.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> index cf351c6..8b1c938 100644
>> --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c
>> @@ -86,7 +86,8 @@ static int its_pci_msi_prepare(struct irq_domain *domain, struct device *dev,
>> pci_for_each_dma_alias(pdev, its_get_pci_alias, &dev_alias);
>>
>> /* ITS specific DeviceID, as the core ITS ignores dev. */
>> - info->scratchpad[0].ul = dev_alias.dev_id;
>> + info->scratchpad[0].ul = of_msi_map_rid(dev, domain->of_node,
>> + dev_alias.dev_id);
>>
>> return msi_info->ops->msi_prepare(domain->parent,
>> dev, dev_alias.count, info);
>
> I really wonder if that shouldn't be part of the pci_for_each_dma_alias
> call. It would make a lot more sense for this functionality to be an
> integral part of the core code, and would probably make the integration
> of _IORT (which has the exact same requirements) a bit easier.
>
> Thoughts?
>

I am a proponent of pushing things like this as far into the core code
as possible. So, from that point of view, I think it would probably be
a good idea.

I can prepare a patch that does that, but it would also be nice hear
from other maintainers and get their thoughts on this.


> M.
>



\
 
 \ /
  Last update: 2015-09-23 19:21    [W:0.296 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site