Messages in this thread | | | Date | Wed, 23 Sep 2015 17:11:06 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v11 3/4] add FPGA manager core |
| |
On Wed, Sep 23, 2015 at 03:23:54PM +0200, Pavel Machek wrote: > > > +int fpga_mgr_firmware_load(struct fpga_manager *mgr, u32 flags, > > > + const char *image_name) > > > +{ > > > + struct device *dev = &mgr->dev; > > > + const struct firmware *fw; > > > + int ret; > > > + > > > + if (!mgr) > > > + return -ENODEV; > > > > Again; I'm of the opinion this is needlessly defensive. > > Not only that, it can never happen. mgr is already dereferenced above. >
It's not dereferenced. We're taking the address of mgr->dev but we don't dereference mgr.
regards, dan carpenter
| |