Messages in this thread | | | Date | Wed, 23 Sep 2015 15:33:49 +0200 | Subject | Re: [RFC v7 25/41] richacl: Isolate the owner and group classes | From | Andreas Gruenbacher <> |
| |
2015-09-22 21:02 GMT+02:00 J. Bruce Fields <bfields@fieldses.org>: > On Sat, Sep 05, 2015 at 12:27:20PM +0200, Andreas Gruenbacher wrote: >> + * Compute the permissions already denied to @who. > > I'm not sure, but may be worth commenting on the lack of everyone denies > here as you do in a couple places below.
Okay.
> As in the owner case, I think a goto would simplify the logic a little.
Yep, I'll clean that up.
>> + /* >> + * Start from the entry before the trailing everyone@ allow >> + * entry. We will not hit everyone@ entries in the loop. > > May as well skip the check below, in that case?
Indeed. You can almost tell from those few leftovers how the code has evolved over time :)
Thanks, Andreas
| |