Messages in this thread | | | Date | Tue, 22 Sep 2015 17:36:29 -0700 (PDT) | Subject | Re: [PATCH v2] lib: fix data race in rhashtable_rehash_one | From | David Miller <> |
| |
From: Dmitry Vyukov <dvyukov@google.com> Date: Tue, 22 Sep 2015 10:51:52 +0200
> rhashtable_rehash_one() uses complex logic to update entry->next field, > after INIT_RHT_NULLS_HEAD and NULLS_MARKER expansion: > > entry->next = 1 | ((base + off) << 1) > > This can be compiled along the lines of: > > entry->next = base + off > entry->next <<= 1 > entry->next |= 1 > > Which will break concurrent readers. > > NULLS value recomputation is not needed here, so just remove > the complex logic. > > The data race was found with KernelThreadSanitizer (KTSAN). > > Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Applied, thanks.
| |