Messages in this thread | | | Date | Mon, 21 Sep 2015 09:33:00 +0200 | From | Hans-Christian Egtvedt <> | Subject | Re: [PATCH 1/3] avr32: fix build failure |
| |
Around Mon 21 Sep 2015 12:09:01 +0530 or thereabout, Sudip Mukherjee wrote: > On Mon, Sep 21, 2015 at 08:09:42AM +0200, Hans-Christian Egtvedt wrote: >> Around Sat 19 Sep 2015 22:42:57 +0530 or thereabout, Sudip Mukherjee wrote: >> > While building avr32 with allmodconfig, the build used to fail with the >> > message: >> > error: implicit declaration of function 'pci_iomap' >> > error: implicit declaration of function 'pci_iounmap' >> >> What has changed recently that start pulling in these? AVR32 does not have >> PCI at all, and will never have it either. Is this exposing a bug somewhere >> else? > It looks like pci_iomap and pci_iounmap doesnot depend on CONFIG_PCI. > So drivers/net/ethernet/via/via-rhine.c is calling these functions even > if PCI is disabled. The build log is at: > https://travis-ci.org/sudipm-mukherjee/parport/jobs/81127188 > > You can find a similar discussion at: > http://www.linux-mips.org/archives/linux-mips/2013-06/msg00510.html
If multiple architectures have similar problems, then a more global definition of these unused functions could be added.
Just move the implementation for MIPS into include/asm-generic/io.h ?
That way we do not have to implement and identical stub for every device not supporting PCI.
-- mvh Hans-Christian Egtvedt
| |