Messages in this thread Patch in this message | | | From | Octavian Purdila <> | Subject | [PATCH] checkpatch: avoid showing BIT_ULL warnings for tools/ files | Date | Mon, 21 Sep 2015 19:30:46 +0300 |
| |
Directly using shift operations in userspace compiled code should not trigger warnings as BIT_ULL macros are not available outside the kernel.
Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> --- scripts/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 407eb6c..93557bf 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5527,7 +5527,8 @@ sub process { if ($line =~ /#\s*define\s+\w+\s+\(?\s*1\s*([ulUL]*)\s*\<\<\s*(?:\d+|$Ident)\s*\)?/) { my $ull = ""; $ull = "_ULL" if (defined($1) && $1 =~ /ll/i); - if (CHK("BIT_MACRO", + if ($realfile !~ m@\btools/@ && + CHK("BIT_MACRO", "Prefer using the BIT$ull macro\n" . $herecurr) && $fix) { $fixed[$fixlinenr] =~ s/\(?\s*1\s*[ulUL]*\s*<<\s*(\d+|$Ident)\s*\)?/BIT${ull}($1)/; -- 1.9.1
| |