Messages in this thread | | | From | Rasmus Villemoes <> | Subject | Re: [RFC PATCH 0/3] fix *pbl format support | Date | Mon, 21 Sep 2015 18:24:13 +0200 |
| |
On Mon, Sep 21 2015, Maurizio Lombardi <mlombard@redhat.com> wrote:
> Hi Rasmus, > > On 09/16/2015 10:35 PM, Rasmus Villemoes wrote: >> >> I just remembered: I noticed a while ago that the qualifier member is >> only used inside format_decode (in the end, the information is folded >> into the type member), so one might as well use a local variable for >> that. This gives option (3): Make field_width a 24 bit bitfield. I think >> that should be sufficient for any realistic bitmap that one would >> print. The patch is also rather small. Surprisingly, bloat-o-meter even >> says that it's also a net win in code size: > > I tested your patch with scsi-debug and it works for me:
Thanks for testing it! What do people think of this option?
Rasmus
| |