Messages in this thread | | | From | Jon Cormier <> | Date | Mon, 21 Sep 2015 09:05:57 -0400 | Subject | Re: [PATCH RFC 6/7] ASoC: tlv320aic26: Add support for DSP_B data format |
| |
On Mon, Sep 21, 2015 at 2:19 AM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > > On 09/18/2015 11:11 PM, Cormier, Jonathan wrote: > > Signed-off-by: Cormier, Jonathan <jcormier@criticallink.com> > > --- > > sound/soc/codecs/tlv320aic26.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/soc/codecs/tlv320aic26.c b/sound/soc/codecs/tlv320aic26.c > > index c3b0a698ea66..5c5641cd28de 100644 > > --- a/sound/soc/codecs/tlv320aic26.c > > +++ b/sound/soc/codecs/tlv320aic26.c > > @@ -211,6 +211,7 @@ static int aic26_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt) > > switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) { > > case SND_SOC_DAIFMT_I2S: aic26->datfm = AIC26_DATFM_I2S; break; > > case SND_SOC_DAIFMT_DSP_A: aic26->datfm = AIC26_DATFM_DSP; break; > > + case SND_SOC_DAIFMT_DSP_B: aic26->datfm = AIC26_DATFM_DSP; break; > > Are you sure about this? According to the datasheet: > www.ti.com/litv/slas412 page 18 there is no bit to change the data delay and > the format the codec supports is DSP_A. I went with DSP_B because thats what the 335x EVM had set and when comparing the tlv320aic26 datasheet to the tlv320aic32 for the DSP mode it seemed to match. I had been getting garbled audio playback when I tested with DSP_A but I just retested to be sure and now DSP_A appears to work just the same as DSP_B. So I suggest we drop this patch. > > > case SND_SOC_DAIFMT_RIGHT_J: aic26->datfm = AIC26_DATFM_RIGHTJ; break; > > case SND_SOC_DAIFMT_LEFT_J: aic26->datfm = AIC26_DATFM_LEFTJ; break; > > default: > > > > > -- > Péter
-- Jonathan Cormier CriticalLink
| |