Messages in this thread | | | Date | Mon, 21 Sep 2015 10:28:27 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] tty/vt: don't set font mappings on vc not supporting this |
| |
On Sun, Sep 20, 2015 at 06:40:15PM -0700, Greg Kroah-Hartman wrote: > On Sun, Sep 13, 2015 at 11:33:51AM +0530, Sudip Mukherjee wrote: > > commit 9e326f78713a4421fe11afc2ddeac07698fac131 upstream <snip> > > Cc: <stable@vger.kernel.org> # 3.14.x > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > > --- > > > > backporting for the first time so not exactly sure if the format is ok. > > You need to keep the original authorship of the patch around, as well as > their signed-off-by information. Also, you didn't backport it > identically: > <snip> > > + > > + if (!p) { > > + err = -EINVAL; > > + goto out_unlock; > > The original has a blank line between these two lines, why not keep it? > > I'll fix it up, but be a bit more careful next time please. Sure, next time you will have no complaints about this.
regards sudip
| |