lkml.org 
[lkml]   [2015]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: linux-next: build failure after merge of the rcu tree
    On Tue, Sep 01, 2015 at 11:40:51PM -0700, Davidlohr Bueso wrote:
    > On Tue, 2015-09-01 at 22:26 -0700, Paul E. McKenney wrote:
    > > Davidlohr, the error is due to sched_setscheduler_nocheck() not being
    > > exported, so that Stephen gets this failure when building modules.
    > > This is 04be76a9b067 (locktorture: Support rtmutex torturing) in -rcu.
    > >
    > > Thoughts?
    >
    > Right, the below should take care of it. Although I think it makes sense
    > to get this into at least 4.3 even if we won't use it until 4.4. Simply
    > because we already export sched_setscheduler(). If you agree I guess we
    > could route via -tip.

    Given an ack from Peter or Ingo, I would happy to queue it. But we are
    talking 4.4 rather than 4.3, sorry!

    Thanx, Paul

    > Thanks,
    > Davidlohr
    >
    > ----8<------------------------------------
    > Subject: [PATCH -next] sched: Export sched_setscheduler_nocheck
    >
    > ... just like regular sched_setscheduler(). We need this, for locktorture
    > otherwise we can fail to build modules, ie:
    >
    > ERROR: "sched_setscheduler_nocheck" [kernel/locking/locktorture.ko] undefined!
    >
    > Signed-off-by: Davidlohr Bueso <dbueso@suse.de>
    > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
    > Cc: Ingo Molnar <mingo@kernel.org>
    > ---
    > kernel/sched/core.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
    > index 3595403..7b51f64 100644
    > --- a/kernel/sched/core.c
    > +++ b/kernel/sched/core.c
    > @@ -4012,6 +4012,7 @@ int sched_setscheduler_nocheck(struct task_struct *p, int policy,
    > {
    > return _sched_setscheduler(p, policy, param, false);
    > }
    > +EXPORT_SYMBOL_GPL(sched_setscheduler_nocheck);
    >
    > static int
    > do_sched_setscheduler(pid_t pid, int policy, struct sched_param __user *param)
    > --
    > 2.1.4
    >
    >
    >



    \
     
     \ /
      Last update: 2015-09-02 09:41    [W:3.970 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site