lkml.org 
[lkml]   [2015]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: perf: possible bug in perf_event__read_size
On Wed, 2 Sep 2015, Vince Weaver wrote:
> Shouldn't that be
>
> if (event->attr.read_format & PERF_FORMAT_ID)
> size += sizeof(u64);

never mind, after a lot of further thought I can see this is a "clever"
hack to allow group events to have an ID for each value.

It's a shame the perf_event code doesn't more comments in the code,
especially when the code is being clever like this.

Vince


\
 
 \ /
  Last update: 2015-09-02 18:01    [W:0.048 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site