Messages in this thread | | | Date | Sat, 19 Sep 2015 10:10:17 -0700 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] ASoC: da7219: Add bindings documentation for DA7219 audio codec |
| |
On Thu, Sep 17, 2015 at 05:01:16PM +0100, Adam Thomson wrote:
> +- dlg,io-lvl : Expected voltage level range for digital IO > + ["2.5V_3.6V", "1.2V_2.8V"]
If the driver needs to read or set the voltage a supply is at it should do that via the regulator API.
> +- dlg,cp-mchange : Charge pump voltage tracking mode > + ["largest_vol", "dac_vol", "sig_mag"] > +- dlg,cp-vol-thresh : Charge pump volume threshold value (6-bit value) > + [ 0 - 0x3F ]
Why are these in the device tree rather than runtime parameters?
> +Child node - 'da7219_aad': > + > +Required properties: > +- interrupt-parent : Specifies the phandle of the interrupt controller to which > + the IRQs from DA7219 AAD block are delivered to. > +- interrupts : IRQ line info for DA7219 AAD block. > + (See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt for > + further information relating to interrupt properties)
Why is this not specified at the device level (the device does not appear to support other interrupts)? [unhandled content-type:application/pgp-signature] | |