lkml.org 
[lkml]   [2015]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] mfd: tps65912: Rewrite driver adding DT support and using regmap
On Tue, Sep 15, 2015 at 12:57:40PM -0500, Andrew F. Davis wrote:
> The old driver does not support DT. Rewrite the driver adding DT support
> and use modern kernel features such as regmap and related helpers.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
> ---
> drivers/gpio/gpio-tps65912.c | 291 ++++++------
> drivers/mfd/Kconfig | 20 +-
> drivers/mfd/Makefile | 3 +-
> drivers/mfd/tps65912-core.c | 288 +++++-------
> drivers/mfd/tps65912-i2c.c | 233 ++++------
> drivers/mfd/tps65912-irq.c | 217 ---------
> drivers/mfd/tps65912-spi.c | 236 ++++------
> drivers/regulator/tps65912-regulator.c | 783 ++++++++++-----------------------
> include/linux/mfd/tps65912.h | 256 +++++++----
> 9 files changed, 854 insertions(+), 1473 deletions(-)

It's not OK to have a single commit that rewrites multiple drivers over
many subsystems, that's really not something that can be sensibly
reviewed. You should split this into a patch series which makes one
specific change at a time as covered in SubmittingPatches. That will
allow the changes to be reviewed much more sensibly.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-09-20 03:01    [W:1.217 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site