lkml.org 
[lkml]   [2015]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] x86/math-emu: Remove define layer for undocumented opcodes

* Denys Vlasenko <dvlasenk@redhat.com> wrote:

> No code changes.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
> CC: Ingo Molnar <mingo@kernel.org>
> CC: Borislav Petkov <bp@alien8.de>
> CC: "H. Peter Anvin" <hpa@zytor.com>
> CC: Andy Lutomirski <luto@amacapital.net>
> CC: Kees Cook <keescook@chromium.org>
> CC: x86@kernel.org
> CC: linux-kernel@vger.kernel.org
> ---
> arch/x86/math-emu/fpu_entry.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)

This patch should come before riskier patches introducing new instructions, to
make eventual reverts and fixes easier.

The rule is generally: sort patches by risk, low risk first, high risk later. This
means that cleanups, restructuring, refactoring patches always come first - beyond
making bisection and reverts easier, those make subsequent patches cleaner as well
and make any bugs in subsequent patches easier to see as well.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-09-18 10:01    [W:0.059 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site