lkml.org 
[lkml]   [2015]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 1/2] drm/vmwgfx: Fix uninitialized return in vmw_cotable_unbind()
Good catch!

Reviewed-by: Sinclair Yeh <syeh@vmware.com>

On Sat, Sep 19, 2015 at 12:31:10AM +0200, Christian Engelmayer wrote:
> Function vmw_cotable_unbind() uses the uninitialized variable ret as
> return value. Make the result deterministic and directly return as
> the variable is unused anyway. Detected by Coverity CID 1324256.
>
> Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
> ---
> Compile tested only. Applies against linux-next.
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
> index ce659a125f2b..092ea81eeff7 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cotable.c
> @@ -311,7 +311,6 @@ static int vmw_cotable_unbind(struct vmw_resource *res,
> struct vmw_private *dev_priv = res->dev_priv;
> struct ttm_buffer_object *bo = val_buf->bo;
> struct vmw_fence_obj *fence;
> - int ret;
>
> if (list_empty(&res->mob_head))
> return 0;
> @@ -328,7 +327,7 @@ static int vmw_cotable_unbind(struct vmw_resource *res,
> if (likely(fence != NULL))
> vmw_fence_obj_unreference(&fence);
>
> - return ret;
> + return 0;
> }
>
> /**
> --
> 1.9.1
>


\
 
 \ /
  Last update: 2015-09-19 01:01    [W:0.031 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site