Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Sat, 19 Sep 2015 00:25:20 +0800 | Subject | Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets |
| |
On Fri, Sep 18, 2015 at 11:32 PM, Hans de Goede <hdegoede@redhat.com> wrote: > Hi, > > On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote: >> >> A23/A33 based Q8 format tablets use channel 0 of the PWM controller for >> backlight dimming. >> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org> >> --- >> arch/arm/boot/dts/sun8i-q8-common.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi >> b/arch/arm/boot/dts/sun8i-q8-common.dtsi >> index 6f8a8bb4e9bb..4c2d0b459d6f 100644 >> --- a/arch/arm/boot/dts/sun8i-q8-common.dtsi >> +++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi >> @@ -70,6 +70,12 @@ >> }; >> }; >> >> +&pwm { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pwm0_pins>; >> + status = "okay"; >> +}; >> + >> &r_uart { >> pinctrl-names = "default"; >> pinctrl-0 = <&r_uart_pins_a>; >> > > I've a feeling this should be in sunxi-q8-common.dtsi not > sun8i-q8-common.dtsi, which requires adding a pwm > node to sun5i.dtsi I'll look into this.
It probably should. IIRC sun5i PWM has only one channel as opposed to 2 on A10/A20.
ChenYu
| |