lkml.org 
[lkml]   [2015]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 6/7] phy: fixed-phy: properly validate phy in fixed_phy_update_state()
    Date
    Validate that the phy_device passed into fixed_phy_update_state() is a
    fixed-phy device before walking the list of phys for a fixed phy at the
    same address.

    Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
    ---
    drivers/net/phy/fixed_phy.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c
    index fb1299c6326e..e23bf5b90e17 100644
    --- a/drivers/net/phy/fixed_phy.c
    +++ b/drivers/net/phy/fixed_phy.c
    @@ -220,7 +220,7 @@ int fixed_phy_update_state(struct phy_device *phydev,
    struct fixed_mdio_bus *fmb = &platform_fmb;
    struct fixed_phy *fp;

    - if (!phydev || !phydev->bus)
    + if (!phydev || phydev->bus != fmb->mii_bus)
    return -EINVAL;

    list_for_each_entry(fp, &fmb->phys, node) {
    --
    2.1.0


    \
     
     \ /
      Last update: 2015-09-18 12:21    [W:4.304 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site