lkml.org 
[lkml]   [2015]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] genirq: Fix bad IRQ_ONSHOT in forced IRQ setting
On Fri, 18 Sep 2015, Kohji Okuno wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> Date: Thu, 17 Sep 2015 23:10:02 +0200
> > On Thu, 17 Sep 2015, Kohji Okuno wrote:
> >>
> >> When 1st sdio IRQ is happend, sdhci_irq() returns IRQ_WAKE_THREAD.
> >> After this, sdhci_irq() is not called in case of threadirqs.
> >
> > What kind of system is that?
> >
> > Can you provide the output of /proc/interrupts please?
> >
> > I think your patch is fine. I just want to understand why we don't see
> > any more interrupts.
> >
> > Thanks,
> >
> > tglx
>
> Hi tglx,
>
> My system is arm, and I connect SDIO WiFi card.
> In fact, I use kernel 3.18.11 base. But, I think sources concerned
> with this are same.
>
> This is my "/proc/interrupts".
>
> CPU0 CPU1 CPU2 CPU3
> 46: 20672 0 0 0 GIC 46 mmc1
>
> In drivers/irqchip/irq-gic.c:gic_set_type(), irq46 is set as
> IRQ_TYPE_LEVEL_HIGH.

That's weird. The flow is:

interrupt()
mask()
ret = primary_handler()
if (ret == WAKE_THREAD)
wake_thread()
else
unmask()

thread_handler()
....
unmask()

So if an interrupt is triggered on the device while the interrupt is
masked it should be raised again immediately when the unmask happens
because its level type.

I'm wondering why that doesn't work.

Thanks,

tglx




\
 
 \ /
  Last update: 2015-09-18 11:21    [W:0.294 / U:1.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site