Messages in this thread | | | Subject | Re: [PATCH v3 3/4] serial: samsung: introduce s3c24xx_serial_rx_drain_fifo() function | From | Krzysztof Kozlowski <> | Date | Thu, 17 Sep 2015 16:35:18 +0900 |
| |
On 15.09.2015 21:48, Robert Baldyga wrote: > This patch introduces s3c24xx_serial_rx_drain_fifo() which reads data > from RX FIFO and writes it to tty buffer. It also checks for special > conditions (such as 'break') and handles it. This function has been > separated from s3c24xx_serial_rx_chars_pio() as it contains code which > can be used also in DMA mode. > > Signed-off-by: Robert Baldyga <r.baldyga@samsung.com> > --- > drivers/tty/serial/samsung.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-)
Thanks for splitting the code. It looks good but I don't feel experienced enough in the driver internals to give a review tag. :)
Best regards, Krzysztof
| |