Messages in this thread | | | Date | Thu, 17 Sep 2015 13:29:05 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH 2/4] ARM: dts: sun7i: Add keypad node to Allwinner A20 SoC |
| |
Hi Yassin,
On Wed, Sep 16, 2015 at 12:05:55AM +1000, yassinjaffer@gmail.com wrote: > From: Yassin Jaffer <yassinjaffer@gmail.com> > > Add Keypad controller node definition to the A20 SoC. > > Signed-off-by: Yassin Jaffer <yassinjaffer@gmail.com> > --- > arch/arm/boot/dts/sun7i-a20.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi > index 333604a..35cc8d0 100644 > --- a/arch/arm/boot/dts/sun7i-a20.dtsi > +++ b/arch/arm/boot/dts/sun7i-a20.dtsi > @@ -1198,6 +1198,15 @@ > status = "disabled"; > }; > > + kp: kp@01c23000 {
The node name should reflect the class of the device. keypad@01c23000 would be better for example.
It looks good otherwise.
Thanks! Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |