lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: wilc1000: Removed unwanted curly braces
On Wed, Sep 16, 2015 at 09:50:50PM +0530, Aparna Karuthodi wrote:
> Removed unwanted curly braces of a single statement if-else block to
> remove a coding style warning detected by checkpatch. The warning is
> given below:
>
> 58: WARNING: braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Aparna Karuthodi <kdasaparna@gmail.com>
> ---
> drivers/staging/wilc1000/fifo_buffer.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/fifo_buffer.c b/drivers/staging/wilc1000/fifo_buffer.c
> index b6c07cf..4fbac3d 100644
> --- a/drivers/staging/wilc1000/fifo_buffer.c
> +++ b/drivers/staging/wilc1000/fifo_buffer.c
> @@ -52,11 +52,10 @@ u32 FIFO_ReadBytes(tHANDLE hFifo, u8 *pu8Buffer, u32 u32BytesToRead, u32 *pu32By
> if (pstrFifoHandler->u32TotalBytes) {
> down(&pstrFifoHandler->SemBuffer);
>
> - if (u32BytesToRead > pstrFifoHandler->u32TotalBytes) {
> + if (u32BytesToRead > pstrFifoHandler->u32TotalBytes)
> *pu32BytesRead = pstrFifoHandler->u32TotalBytes;
> - } else {
> + else

The indenting is wrong here. There is an extra space char.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-09-16 22:41    [W:0.031 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site