lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 1/3] regmap: irq: add support for chips who have separate unmask registers
On Mon, Sep 14, 2015 at 09:40:08AM +0000, Barry Song wrote:

> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -800,12 +800,15 @@ struct regmap_irq {
> *
> * @status_base: Base status register address.
> * @mask_base: Base mask register address.
> + * @unmask_base: Base unmask register address. for chips who have
> + * separate mask and unmask registers
> * @ack_base: Base ack address. If zero then the chip is clear on read.
> * Using zero value is possible with @use_ack bit.
> * @wake_base: Base address for wake enables. If zero unsupported.
> * @irq_reg_stride: Stride to use for chips where registers are not contiguous.
> * @init_ack_masked: Ack all masked interrupts once during initalization.
> * @mask_invert: Inverted mask register: cleared bits are masked out.
> + * @unmask_separate: unmask is separate register from mask.

We shouldn't need this - we should just be able to check if there's an
unmask_base set and use that.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-09-16 22:01    [W:0.042 / U:0.756 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site