Messages in this thread | | | Date | Wed, 16 Sep 2015 07:16:14 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 4/5] xattr handlers: Pass handler to operations instead of flags |
| |
On Fri, Sep 04, 2015 at 01:57:21PM +0200, Andreas Gruenbacher wrote: > The xattr_handler operations are currently all passed a file system specific > flags value which the operations can use to disambiguate between different > handlers; some file systems use that to distinguish the xattr namespace, for > example. In some oprations, it would be useful to also have access to the > handler prefix. To allow that, pass a pointer to the handler to operations > instead of the flags value alone.
Looks ok, but the more usual calling convention would be to pass the handler as the first argument.
| |