lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 13/31] memstick: use kmemdup rather than duplicating its implementation
From
Date
Ping.

Regards
Andrzej


On 08/07/2015 09:59 AM, Andrzej Hajda wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/memstick/core/mspro_block.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
> index 922a750..1f1dd9b 100644
> --- a/drivers/memstick/core/mspro_block.c
> +++ b/drivers/memstick/core/mspro_block.c
> @@ -1033,12 +1033,11 @@ static int mspro_block_read_attributes(struct memstick_dev *card)
> }
> msb->attr_group.name = "media_attributes";
>
> - buffer = kmalloc(attr_len, GFP_KERNEL);
> + buffer = kmemdup((char *)attr, attr_len, GFP_KERNEL);
> if (!buffer) {
> rc = -ENOMEM;
> goto out_free_attr;
> }
> - memcpy(buffer, (char *)attr, attr_len);
>
> for (cnt = 0; cnt < attr_count; ++cnt) {
> s_attr = kzalloc(sizeof(struct mspro_sys_attr), GFP_KERNEL);



\
 
 \ /
  Last update: 2015-09-16 12:21    [W:0.600 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site