lkml.org 
[lkml]   [2015]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip 2/3] sched/wake_q: Relax to acquire semantics
On Tue, Sep 15, 2015 at 12:49:46PM -0700, Davidlohr Bueso wrote:
> On Tue, 15 Sep 2015, Peter Zijlstra wrote:
>
> >>Secondly, the wake queues are not concurrent, they're in context, so I
> >>don't see ordering matter at all. The only reason its a cmpxchg() is
> >>because there is the (small) possibility of two contexts wanting to wake
> >>the same task, and we use task_struct storage for the queue.
> >
> >I don't think we need _any_ barriers here, unless we have concurrent
> >users of the wake queues (or want to allow any, do we?).
>
> Exactly, the queues are not concurent and do not need barriers, but some of
> our callers do expect them.

Ah, that is what you were saying. In that case, I think we should remove
all our barriers and make them explicit in the callers where needed.


\
 
 \ /
  Last update: 2015-09-16 11:21    [W:0.077 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site