lkml.org 
[lkml]   [2015]   [Sep]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5 v2] mm/memblock: Introduce memblock_first_region_size() helper
On Tue,  1 Sep 2015 20:27:11 +0600 Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> Some architectures (like s390, microblaze and etc...) require size
> of the first memory region. This patch provides new memblock_first_region_size()
> helper for this case.
>
> ...
>
> +phys_addr_t __init_memblock memblock_first_region_size(void)
> +{
> + return memblock.memory.regions[0].size;
> +}
> +

Some callers call this from __init code, which is OK.

Other callers call it from an inlined function and I'm too lazy to work
out if all the callers of those callers are calling
memblock_first_region_size() from a compatible section.

So please either a) demonstrate that all the sectioning is correct (and
maintainable!) or b) simply inline memblock_first_region_size()...



\
 
 \ /
  Last update: 2015-09-16 01:41    [W:0.034 / U:2.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site